ryanheise

Results 1670 comments of ryanheise

What do you mean by "fake" notification? Just copying my comment from #849 : > I originally wanted to get rid of `notificationCreated` completely so that it would be possible...

I didn't mean to imply that it was the same thing, in fact mine is quite a different approach but it seemed you wanted the discussion of my approach over...

With 2a, I think I could support that via `androidResumeOnClick = true`. I think 3 should also be supported by setting the state to `idle`.

> > I think 3 should also be supported by setting the state to `idle`. > > How do you distinguish between 1a and 3? In both cases you have...

> I see it now. I don't like the fact that there's a moment where notification is shown but cannot be updated, i.e. when `androidResumeOnClick=true`, and we just became `idle`....

I forgot to mention that what I said above should not just consider `setState` but also `setMetadata` since that will also update the notification.

Simple solution to that: notification is cancelled as soon as `idle && !androidResumeOnClick`.

One thing I just want to be careful of with this change is that I don't cause a regression of #462 which I think is when I first introduced the...

Just thinking on this more, are you able to share the actual use case where you want to show the notification before entering foreground? I want to ensure that whatever...

Maybe there is also a way to combine both approaches where by default the plugin tries to implement best practices for a media app by showing the notification on `startForeground`,...