audio_service icon indicating copy to clipboard operation
audio_service copied to clipboard
verified publisher icon ryanheise

Check for SkParagraph enable status, and pass it to the created engine

Open limitless-brain opened this issue 3 years ago • 2 comments

Check for SkParagraph enable status, and pass it to the created engine bug fix for the issue.

limitless-brain avatar May 29 '22 11:05 limitless-brain

Thanks @limitless-brain for the PR. I'd definitely like to incorporate your contribution. I have left some comments regarding the diff that I'd like you to address before I can review it and see which lines you have actually changed. In addition to those two comments, there are many other locations where formatting changes should be undone before review.

ryanheise avatar May 29 '22 12:05 ryanheise

Thanks @limitless-brain for the PR. I'd definitely like to incorporate your contribution. I have left some comments regarding the diff that I'd like you to address before I can review it and see which lines you have actually changed. In addition to those two comments, there are many other locations where formatting changes should be undone before review.

Noted, I will undo the formatting.

limitless-brain avatar May 29 '22 14:05 limitless-brain