audio_service icon indicating copy to clipboard operation
audio_service copied to clipboard

FEAT: implemented MPNowPlayingInfoPropertyIsLiveStream

Open MuradSh opened this issue 2 years ago • 4 comments

Adding MPNowPlayingInfoPropertyIsLiveStream, so we can livestream audio with just_audio.

Pre-launch Checklist

  • [x] I read the CONTRIBUTING.md and followed the process outlined there for submitting PRs.
  • [x] My change is not breaking and lands in minor branch OR my change is breaking and lands in major branch.
  • [x] If I'm the first to contribute to the next version, I incremented the version number in pubspec.yaml according to the pub versioning philosophy.
  • [x] I updated CHANGELOG.md to add a description of the change (format: * DESCRIPTION OF YOUR CHANGE (@your-git-username)).
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I ran dart analyze.
  • [x] I ran dart format.
  • [x] I ran flutter test and all tests are passing.

MuradSh avatar Oct 04 '23 19:10 MuradSh

Hi, some news about this PR?

tongo avatar Apr 03 '24 14:04 tongo

Hi @ryanheise,

I hope you are well.

I've noticed there are three issues related to the MPNowPlayingInfoPropertyIsLiveStream feature, and this PR seems to address them well. It would be great to close all three issues with this simple implementation. Is this going to be merged or implemented soon?

Thanks for your hard work on audio_service.

mahdi-rafiei avatar May 21 '24 16:05 mahdi-rafiei

@ryanheise Hi! Can we move forward with this PR?

MuradSh avatar Oct 01 '24 04:10 MuradSh

Yes, at a cursory glance it looks good. I will take a more serious look on the weekend before merging.

ryanheise avatar Oct 02 '24 15:10 ryanheise

This PR has now been merged and released. I realise actually both @MuradSh and @celsoft worked on almost identical PRs so both are credited in the CHANGELOG.

ryanheise avatar Dec 14 '24 14:12 ryanheise