audio_service icon indicating copy to clipboard operation
audio_service copied to clipboard

fixing issue 1016

Open mhassan772 opened this issue 2 years ago • 3 comments

This change here is fixing the 1016 issue. https://github.com/ryanheise/audio_service/issues/1016 It is basically solving the problem based on this guidance here: https://developer.apple.com/forums/thread/654413

Pre-launch Checklist

  • [X] I read the CONTRIBUTING.md and followed the process outlined there for submitting PRs.
  • [X] My change is not breaking and lands in minor branch OR my change is breaking and lands in major branch.
  • [X] If I'm the first to contribute to the next version, I incremented the version number in pubspec.yaml according to the pub versioning philosophy.
  • [I couldn't find it ] I updated CHANGELOG.md to add a description of the change (format: * DESCRIPTION OF YOUR CHANGE (@mhassan772)).
  • [X] I updated/added relevant documentation (doc comments with ///).
  • [x] I ran dart analyze.
  • [x] I ran dart format.
  • [x] I ran flutter test and all tests are passing.

It is a very minor change

mhassan772 avatar May 03 '23 00:05 mhassan772

@mhassan772 Thanks for the fix.

@ryanheise We really want to merge this fix to our fork version of audio_service. Could the code has any side effect?

838 avatar Aug 21 '23 08:08 838

I am reviewing this PR now, thanks.

ryanheise avatar Aug 28 '23 08:08 ryanheise

How did the review go?

mhassan772 avatar Oct 05 '23 11:10 mhassan772

My sincere apologies, I recently caught up with my iOS todo list, and this PR is now merged and published. Thank you @mhassan772 for the contribution.

ryanheise avatar Feb 04 '25 09:02 ryanheise