fixed all C++ warnings

[GregTalotta]

I ran static analysis tools on the C++ code. Then fixed all warnings.

[ryanhaining]

The comparisons are done intentionally, the minimum requirements for an iterator that works with ranged-for include operator!= but not operator== so I only rely on the former. The iteratoriterator tests are verifying that the given operators work predictably.