Guillermo Guerrero

I don't why but the CI is not triggered...

@mainameiz sorry for the late response, I think your opinion is subjective. At the library point of view, you have documentation, tests and make easier the integrations (provided by community)...

@gaffneyc is not possible to use the http_proxy because right now is not calling with the good parameters to the method start. Here you have the link to the documentation...

the current code is overriding the p_addr => `HTTP.start(address, port=nil, p_addr=:ENV, p_port=nil, p_user=nil, p_pass=nil, opt, &block)` And removes the default value :ENV

My proposal fixes the parameters order and allows more flexibility to configure the proxy passing options.

@gaffneyc not working your proposal with the current code: ```ruby Net::HTTP.start(uri.host, uri.port, opts) do |http| ... opts = hash { with timeouts... } ``` The current code overrides the parameter...

The current code sends `p_addr = opts`, it's wrong

@gaffneyc I reviewed the source and you are right. The first line removes the last argument if it's a hash: `arg.pop if opt = Hash.try_convert(arg[-1])` and this line forces the...

Yep I agree that could be redundant with downloading, I'm trying to learn play music and this share feature saves / make easier to me to share the song with...

about the quality, I was wondering if there is a better quality than `m4a` and then the downlading is already using the best quality, isn't? - https://github.com/ryanfox1985/Musify/blob/play_playlist/lib/API/musify.dart#L964 - https://github.com/ryanfox1985/Musify/blob/play_playlist/lib/API/musify.dart#L1114