vogels icon indicating copy to clipboard operation
vogels copied to clipboard

Retry logic will indefinitely retry

Open nonken opened this issue 7 years ago • 0 comments

When hitting Dynamo throttling limits (429s), Vogels will indefinitely retry and never back out.

https://github.com/ryanfitz/vogels/blob/master/lib/batch.js#L45-L47

The AWS-SDK attaches a retryable property to the error object for 500s and 429s. This behaviour can bring hosts down as async.doWhilst will just retry forever. I think it is better to not handle retries at all and let the SDK handle this.

See also: https://github.com/ryanfitz/vogels/issues/63

nonken avatar Nov 18 '17 11:11 nonken