nginx-buildpack icon indicating copy to clipboard operation
nginx-buildpack copied to clipboard

Heroku Cedar 16 throwing new error on first build.

Open chavenor opened this issue 7 years ago • 11 comments

Did some searching on google didn't find much. Any ideas? Is it possible that nginx upstream pgk hasn't been built for heroku-16 yet?

-----> nginx-buildpack app detected
cp: cannot stat 'bin/nginx-heroku-16': No such file or directory
 !     Push rejected, failed to compile nginx-buildpack app.
 !     Push failed

chavenor avatar Mar 23 '17 18:03 chavenor

Current workaround for me is heroku stack:set cedar-14 -a <app_name>, but obviously it's not the right way.

asnelzin avatar Apr 28 '17 12:04 asnelzin

But why it does not work on heroku-16?

moohkooh avatar Jun 13 '17 18:06 moohkooh

@moohkooh because it's uses $STACK variable here: https://github.com/ryandotsmith/nginx-buildpack/blob/master/bin/compile#L7

asnelzin avatar Jun 13 '17 20:06 asnelzin

I am getting the same error. It would be great to update it for heroku-16 stack and also add http_gzip_static_module since I think most of us use precompressed files now.

Igor-Vuk avatar Jun 24 '17 21:06 Igor-Vuk

asnelzin - Thanks! Workaround works seamlessly ;-).

One question though. What if tomorrow heroku-16 stack is updated with the package? How to switch from cedar-14 to heroku-16? Thanks much in advance!

sandeep-s avatar Jun 30 '17 06:06 sandeep-s

@sandeep-s

heroku stack:set heroku-16 -a <app_name>

filipgolonka avatar Jul 27 '17 09:07 filipgolonka

Is there any news on this ? Can anyone explain how is it possible this repository has so much issues and pull request going on and the last commit was made 3 years ago ? Couldn't all people using this module agree to make it a kind of community plugin addon forking it ? To be clear I don't want to blame anyone here: I just don't understand what's going on...

edouardmenayde avatar Aug 31 '17 20:08 edouardmenayde

@edouardmenayde this is how open source community is working (sometimes) :) feel free to fork the repo and make a change :)

filipgolonka avatar Sep 01 '17 05:09 filipgolonka

@filipgolonka Not necessarily : puppet has some amazing community modules for heavily used ones for example.

edouardmenayde avatar Sep 01 '17 09:09 edouardmenayde

Hi there, looking at the Heroku PR, I found: heroku/heroku-buildpack-nginx#4 and digging a bit more into @kuwabarahiroshi work, I figured a solution which works for me:

heroku buildpacks:add --index 1 https://github.com/kuwabarahiroshi/heroku-buildpack-nginx.git

lolobosse avatar Oct 14 '17 14:10 lolobosse

The Heroku fork of this repo has been updated to support Heroku-16. Similar to @lolobosse's response, you should be able to run:

heroku buildpacks:add --index 1 https://github.com/heroku/heroku-buildpack-nginx.git

jmejia avatar Dec 22 '17 20:12 jmejia