Ryan Carsten Schmidt

Results 570 comments of Ryan Carsten Schmidt

> error: type ‘…’ violates the C++ One Definition Rule [-Werror=odr] This message can also be seen—as a warning—in the GitHub Actions logs for ubuntu-latest in this repository, which builds...

The same problem exists for ztsd in some cases. Zstd has several build systems, but only their cmake build system produces the zstdConfig.cmake file GLE's build currently requires: https://github.com/facebook/zstd/issues/3271 In...

Before investing time in trying to fix this, I'd like to understand why GLE looks for jbig, zstd, lzma, and deflate at all, because it doesn't use them. Searching for...

This patch allowed me to get through `cmake` and `make` without having Qt (or ghostscript which as far as I know is only used by the Qt GUI): ```diff ---...

> However `make install` didn't actually install anything. I see this is because files only get installed when `CMAKE_BUILD_TYPE` is `Release` or `Debug`: https://github.com/vlabella/GLE/blob/97cf2ca024ef9a12abf6fe6024439faf0c82a0e8/src/gle/CMakeLists.txt#L192-L194 (I was using a different build...

Similarly, GLE 4.3.4 installs the directory `$PREFIX/font/`. Like `doc`, `font` is not a legal top-level directory name according to the [FHS](https://refspecs.linuxfoundation.org/fhs.shtml). In GLE 4.2.5, the `font` directory was inside `$PREFIX/share/gle-graphics/$VERSION/`....

Specifically, Apple clang 12 and later and llvm.org clang 16 and later consider this to be an error.

This causes problems when upgrading; see https://trac.macports.org/ticket/71189.

If this PR changes files that are installed, the revision must be increased. It sounds like the changes in this PR are not the correct way to fix this problem.

Looks like this (except for the fix in html/index.html) was done in 6700bc3f95ccf8ad36dcf791c196fc6090b7db4d.