javaagent-gradle-plugin icon indicating copy to clipboard operation
javaagent-gradle-plugin copied to clipboard

Plugin overwrites applicationDefaultJvmArgs

Open tajobe opened this issue 1 year ago • 1 comments

Using the application plugin, applicationDefaultJvmArgs are inherited by the distribution, however applying this plugin causes those to be overwritten/ignored.

Without the plugin applied, I can set:

application {
    // ...
    applicationDefaultJvmArgs = listOf("-Dabc=123")
}

...and I see DEFAULT_JVM_OPTS='"-Dabc=123"' in the dist script. If I apply the plugin, that is removed/replaced with EG DEFAULT_JVM_OPTS="-javaagent:$APP_HOME/agent-libs/opentelemetry-javaagent-2.1.0.jar" despite the arg still being in my application block. It would be nice for these to play nice as that's an easy way to globally set default opts for all tasks/everywhere the application is used.

tajobe avatar Feb 23 '24 21:02 tajobe

Thanks @tajobe! I thought i had a test case for this, but clearly not, i'll work on a patch for this when I get the opportunity (happy to accept a contribution for this as well)

ryandens avatar Apr 26 '24 15:04 ryandens