javaagent-gradle-plugin icon indicating copy to clipboard operation
javaagent-gradle-plugin copied to clipboard

:recycle: Eliminate dependency on shadow plugin for the OTel Plugin

Open ryandens opened this issue 2 years ago • 0 comments

The OTel plugin applies the com.github.johnrengelman.shadow plugin to your project. This is done in order to unpack the JARs depended on in the otelInstrumentation, rename the compiled class files from *.class to *.classdata, and merging the contents of SPI files in **/META-INF/services/. This often results in a command line warning from Gradle due to an issue with the shadow plugin. When this is fixed in the shadow plugin, updating the transitive dependency will be sufficient.

However, it is a goal of this project to eliminate the dependency on the shadow plugin as it's rather heavy-handed for a task of this type and forces the application of another plugin on the user's project. But, the time I had scoped to spend on implementing the OpenTelemetry feature was running out and I preferred to push something rather than nothing at all.

ryandens avatar May 15 '22 20:05 ryandens