LoginRegister icon indicating copy to clipboard operation
LoginRegister copied to clipboard

E-Mail authentication - PHP notice when registered user types in wrong password

Open WebWorkingMan opened this issue 6 years ago • 3 comments

Hey, I've figured out an error:

I'm using the option "Use email address for login rather than user name". When a registered user tries to login and types in the wrong password I get an PHP notice:

Notice: Trying to get property of non-object in /mnt/***/site/modules/LoginRegister/LoginRegister.module on line 394

This behavior is reproducible on two sites of mine

WebWorkingMan avatar Oct 14 '17 12:10 WebWorkingMan

Also, if a user types in a wrong password a few times (and the right e-mail) Session Login Throttle kicks in and leaves the user with a internal server error instead of a helpful message.

salvw avatar Apr 26 '18 13:04 salvw

Same here, on first test to login....

As for the Login Throttle see: https://github.com/ryancramerdesign/LoginRegister/issues/10

somatonic avatar Oct 16 '18 15:10 somatonic

Line 394 needs to be changed to something like:

$name = $user ? $user->name : null;

Toutouwai avatar Feb 08 '19 04:02 Toutouwai