brainflayer icon indicating copy to clipboard operation
brainflayer copied to clipboard

Segwit Support

Open Napulsnik opened this issue 3 years ago • 11 comments

Hello. Please add support for segwit addresses that start with "3" and "bc1"

Napulsnik avatar Dec 29 '20 23:12 Napulsnik

bc1 addresses will work fine using compressed public key mode if you extract the hash160. I will see about adding support for P2SH-P2WPKH addresses, should be doable.

ryancdotorg avatar Jan 12 '21 11:01 ryancdotorg

Thank you.

Napulsnik avatar Jan 12 '21 13:01 Napulsnik

Figured out how to handle P2SH-P2WPKH as well. Need to merge a bunch of my old unreleased work as dependencies though, so may take some time.

ryancdotorg avatar Jan 17 '21 10:01 ryancdotorg

Thank you for continuing to support the project.

Napulsnik avatar Jan 17 '21 11:01 Napulsnik

I was wondering how it works with the different lengths available for bc1 addresses - example: address: bc1q3qpt7g4nn54pqswum5hezuygg2lyvyy9eshzgh hash160: 8802bf22b39d2a1041dcdd2f91708842be461085 address: 1DQABvofrTfkG39GQmzqVCAoTwQNmPfy1q hash160: 8802bf22b39d2a1041dcdd2f91708842be461085 These two addresses both resolve to the same hash with length 40 characters

This bc1 address is longer and the hash is 62 characters. This will not be picked up by hashing any compressed "1" address; or am I wrong? address: bc1qgdjqv0av3q56jvd82tkdjpy7gdp9ut8tlqmgrpmv24sq90ecnvqqjwvw97 hash160: 4364063fac8829a931a752ecd9049e43425e2cebf83681876c556002bf389b00

2595raven avatar Feb 07 '21 17:02 2595raven

hello Ryan, I am sending you a message because I have a question. I'd like to know if the h160 bc1 address is supported for the version that is currently being provided. In particular, you predicted P2SH-P2WPKH support, so please let me know when you will release the additional version.

seokchul-kwon avatar Mar 07 '21 23:03 seokchul-kwon

Hi, I'm ready to pay for the brainflayer upgrade (segwit)

stalker0007 avatar Oct 11 '21 10:10 stalker0007

@stalker0007 I'm pretty sure you didn't pay me... what address did you send to?

ryancdotorg avatar Oct 25 '21 18:10 ryancdotorg

@stalker0007 Oh, you're offering to pay? Sorry, I didn't read your comment quite right. Please contact me via email, my details are on my site: https://rya.nc/contact

ryancdotorg avatar Oct 25 '21 18:10 ryancdotorg

@chandler-hs You must unsubscribe yourself from via the associated GitHub account, nobody can do it for you.

ryancdotorg avatar Oct 25 '21 19:10 ryancdotorg