nested_form icon indicating copy to clipboard operation
nested_form copied to clipboard

changed to use button_to_add instead of link_to_add to make it more sema...

Open leckylao opened this issue 12 years ago • 3 comments

By reading the article by Heydon http://coding.smashingmagazine.com/2013/08/20/semantic-css-with-intelligent-selectors/. And using the https://github.com/Heydon/REVENGE.CSS.

We would see the warning message for link_to_remove is something like: "Do you mean for this to be a link or a

And warning message for link_to_add is something like "If you are going to make it look like a button, make it a button, dammit!"

Therefore, I decided to make a PR for this. Using button instead of link to make it more semantic.

leckylao avatar Sep 24 '13 06:09 leckylao

It works on Rails 4 and tests all passed now

leckylao avatar Sep 25 '13 00:09 leckylao

:+1:

sunny avatar Dec 01 '13 15:12 sunny

+1

singpolyma avatar Mar 10 '14 21:03 singpolyma