softened-similarity-learning icon indicating copy to clipboard operation
softened-similarity-learning copied to clipboard

Hi,I found another problem with your code

Open chongyangwang-song opened this issue 4 years ago • 4 comments

QQ截图20201130211012 memory_table.py line53 probability function should be matrix multiplication,not element-wise? and this should be modified as following? QQ截图20201130211409

chongyangwang-song avatar Nov 30 '20 13:11 chongyangwang-song

I don't remember the details, but when I wrote that part, I wasn't satisfied with the matmul operation (I don't remember the reason). So I had to an element-wise multiplication and a sum afterward. It may seem weird, but the result should be correct. You can check it again, or replace it with matmul and see how it goes.

ryanaleksander avatar Dec 01 '20 02:12 ryanaleksander

I replace it,and everything turn to be bad. I'm going to give it up

------------------ 原始邮件 ------------------ 发件人: "Lâm Tuấn Anh"<[email protected]>; 发送时间: 2020年12月1日(星期二) 上午10:25 收件人: "ryanaleksander/softened-similarity-learning"<[email protected]>; 抄送: "王重阳"<[email protected]>; "Author"<[email protected]>; 主题: Re: [ryanaleksander/softened-similarity-learning] Hi,I found another problem with your code (#5)

I don't remember the details, but when I wrote that part, I wasn't satisfied with the matmul operation (I don't remember the reason). So I had to an element-wise multiplication and a sum afterward. It may seem weird, but the result should be correct. You can check it again, or replace it with matmul and see how it goes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

chongyangwang-song avatar Dec 01 '20 02:12 chongyangwang-song

微信:sdy19971029

---Original--- From: "xiaosu920"<[email protected]> Date: Wed, Dec 23, 2020 10:40 AM To: "ryanaleksander/softened-similarity-learning"<[email protected]>; Cc: "chongyangwang-song"<[email protected]>;"Author"<[email protected]>; Subject: Re: [ryanaleksander/softened-similarity-learning] Hi,I found another problem with your code (#5)

嗨,您好,可以加个微信交流下这个代码嘛

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

chongyangwang-song avatar Dec 23 '20 02:12 chongyangwang-song

我不记得详细信息,但是当我写那部分时,我对matmul操作并不满意(我不记得原因)。所以我必须逐个元素地进行乘法,然后再求和。看起来很奇怪,但结果应该是正确的。您可以再次检查它,或将其替换为matmul并查看其运

我不记得详细信息,但是当我写那部分时,我对matmul操作并不满意(我不记得原因)。所以我必须逐个元素地进行乘法,然后再求和。看起来很奇怪,但结果应该是正确的。您可以再次检查它,或将其替换为matmul并查看其运行情况。

您好,可以加个微信交流一下嘛

xiaosu920 avatar Dec 23 '20 03:12 xiaosu920