sphinx-bootstrap-theme icon indicating copy to clipboard operation
sphinx-bootstrap-theme copied to clipboard

Support for bootstrap 4?

Open hsingh23 opened this issue 7 years ago • 6 comments

What's the roadmap for supporting bootstrap 4?

hsingh23 avatar Aug 01 '16 18:08 hsingh23

For me personally, supporting existing 2 / 3 is my main priority unless I get a huge chunk of free time for this project...

If someone can take the lead on getting a bootstrap4 port going, I'll definitely take and help support / work out the kinks of a pull request!

ryan-roemer avatar Aug 01 '16 18:08 ryan-roemer

If anybody is interested in getting started with this, the TODO.html page shows what is needed as far as embedding the actual bootstrap / bootswatch resources go.

Unfortunately, it is unlikely that simply enabling bootstrap 4 is going to work out. Ideally, somebody familiar with the actual bootstrap internals / incompatibilities would chime in here

svenevs avatar Nov 24 '17 20:11 svenevs

I would welcome a PR for BS4. And it may be worth considering just semver majoring this library to v1.0.0 with only BS4 support.

While I don't have a ton of time for this, I can help with any JavaScript-related hurdles or issues as that's what I do for my day job, and have a very good familiarity with all that arcana...

ryan-roemer avatar Nov 25 '17 06:11 ryan-roemer

Bumping major and committing to bs4 makes a lot of sense. I've been slowly learning of the new bs4 stuff, and I think the amount of changes that need to happen are too unwieldy to try and make 2/3/4 compatible code. My understanding is we need to fully switch to "cards" for most of this.

svenevs avatar Apr 06 '18 17:04 svenevs

Looks like there's an independent Sphinx on Bootstrap 4 effort at myyasuda/sphinxbootstrap4theme (demo)

artob avatar Jun 01 '18 11:06 artob

FWIW Bootstrap 5 (alpha) has now been released: https://v5.getbootstrap.com/

More info here: https://blog.getbootstrap.com/2020/06/16/bootstrap-5-alpha/

nbara avatar Jun 18 '20 08:06 nbara