sphinx-bootstrap-theme icon indicating copy to clipboard operation
sphinx-bootstrap-theme copied to clipboard

add relbar (breadcrumbs)

Open shiumachi opened this issue 10 years ago • 11 comments

This patch introduces relbar macro (breadcrumbs). The macro is turned off by default. If user want to turn on this feature, set 'relbar_enable' to 'true'.

shiumachi avatar Jun 01 '14 13:06 shiumachi

Can you post screenshots of this in the demo?

ryan-roemer avatar Jun 01 '14 20:06 ryan-roemer

Here is the screenshot:

relbar_example

If you want to include this into repository, please let me know where is the best place to put the image.

I've found that a new page is needed to show this feature. I'll add the page into the PR.

shiumachi avatar Jun 01 '14 22:06 shiumachi

@shiumachi -- Thanks for the additional work. I'm actually out of the country, so won't get a chance to try this out until a week from now. So if I'm out of touch until then it's because of that and I'll pick things up after. Thanks again!

ryan-roemer avatar Jun 02 '14 06:06 ryan-roemer

np, no need to hurry. Enjoy your trip!

shiumachi avatar Jun 02 '14 20:06 shiumachi

@shiumachi -- Can you split this into two options or a different type of configuration to allow top and / or bottom relbars to be shown?

@russell -- Any thoughts on this one?

ryan-roemer avatar Jun 18 '14 15:06 ryan-roemer

@ryan-roemer it does seem more naturall to have a relbar at the top only. I don't think it really matters if it's one opiton or two. Probably one option would be more clear to the user.

russell avatar Jun 19 '14 22:06 russell

Hi @ryan-roemer and @russell,

IMO current option would be enough. User can override relbar1 or relbar2 in layout.html to remove top or bottom relbar:

{% block relbar2 %}{% endblock %}

This is the same way which is mentioned in Sphinx official document. http://sphinx-doc.org/templating.html

But if you guys think it's better to have two option for relbars, I can put it in my patch. There is two way:

a) split into two options relbar1_enable and relbar2_enable b) add new option relbar_position which can be set to top, bottom, or both (default).

shiumachi avatar Jun 21 '14 03:06 shiumachi

Hi @shiumachi -- I like the idea of not having to override the base template to disable this new functionality. Let's go for:

  • add new option relbar_position which can be set to top, bottom, both, none. And make none the default.

/cc @russell

ryan-roemer avatar Jun 21 '14 15:06 ryan-roemer

Is this implemented?

piernik avatar Oct 20 '16 08:10 piernik

@piernik you're looking at the exact current state of implementation right here. If you would like to open a new PR that is

  • caught up to current master
  • implements my final requested tweaks at https://github.com/ryan-roemer/sphinx-bootstrap-theme/pull/102#issuecomment-46755889

that would be awesome!

ryan-roemer avatar Oct 20 '16 09:10 ryan-roemer

sorry but I don't know anything about shipx and/or python and/or github :/

piernik avatar Oct 20 '16 10:10 piernik