Ryan Roemer

Results 206 comments of Ryan Roemer

I've captured "copy and pasteable code blocks" separately as a feature request in: https://github.com/FormidableLabs/spectacle/issues/928

*Update*: current WIP PR fixes this with correct spacing (and it's real spaces too) in MD -- https://github.com/FormidableLabs/spectacle/pull/934 ![Screen Shot 2020-07-28 at 11 05 33 AM](https://user-images.githubusercontent.com/445557/88704194-9b8a8200-d0c2-11ea-9691-98e1ffbf91e5.png)

@ScriptedAlchemy @ethersage -- Thanks for the contributions and work! @boygirl (our OSS lead) and I really need to touch base with @divmain (the lead maintainer, currently at another company) and...

Hi @ScriptedAlchemy, Formidable as been in a bit of holding pattern on this repo, and we'd like to enable the community to get back to it and hopefully pick up...

@ethersage @ScriptedAlchemy -- Just to place a note here: I'm down to support either of you kicking things off if y'all have a mutually agreed "next step" for the project!...

@divmain -- Rando thoughts: Why don't we try the full other way too since you've got concat either way, e.g. ```js // 1. back to array attrString.push(' '); attrString.push(attrKey); attrString.push(attrVal);...

@aweary -- I took your example and did a "pure concatenation" with no backticks: ```diff diff --git a/benchmark.js b/benchmark.js index 9023582..0025857 100644 --- a/benchmark.js +++ b/benchmark.js @@ -2,6 +2,7 @@...

@aweary -- Updated my comment with node6 results

To help my understanding of the changes involved, can someone point me to how React handles things or a pseudo-code diff of what the changes would involve to be immutable-compatible?

@katzmannn -- Can you give us a code sample of what you're trying to do to help with more specificity for our understanding of the issue? Thanks! Either code snippets...