thanks_for_posts icon indicating copy to clipboard operation
thanks_for_posts copied to clipboard

Published 20 hours ago • verified publisher icon rxu

phpbb 3.2.4 thankslist action bar location(class) fixed

Open simpss opened this issue 6 years ago • 4 comments

in phpbb 3.2.4 the "action-bar" element uses "bar-top" class for alignment, not "top" anymore. This MR updates the class in styles/prosilver/template/thankslist_body.html

simpss avatar Nov 22 '18 18:11 simpss

@rxu it’s ok?

Galixte avatar May 19 '19 21:05 Galixte

Couldn't find any css definition of bar-top. Does it have any meaning?

rxu avatar Feb 07 '20 15:02 rxu

Couldn't find any css definition of bar-top. Does it have any meaning?

It did in version 3.2.4, it replaced the previous "top" reference. Can't really remember any more exact details tbh.

I needed it to fix my layout when I originally created the PR.

simpss avatar Feb 09 '20 21:02 simpss

@simpss it’s older than phpBB 3.2.4.

I found two commits about that: https://github.com/phpbb/phpbb/commit/f6ee0152edff08023c33c2ecb49a0251d2926408 https://github.com/phpbb/phpbb/pull/3851/commits/2523ec82776dc2afcfac79c159bbeb9a2fc87b0e

Galixte avatar Feb 17 '20 14:02 Galixte

Merged with d70c68c.

rxu avatar Apr 15 '24 03:04 rxu