speech_recognition icon indicating copy to clipboard operation
speech_recognition copied to clipboard

Published 20 hours ago • verified publisher icon rxlabz

Fix crash when calling installTap

Open robsonmeemo opened this issue 5 years ago • 7 comments

We need to make sure removeTap is always called before installTap is called. Before this PR there was a race condition that led to installTap being called without first removing the previous installTap.

2019-04-09 14:17:55.559484-0700 Runner[33324:2600082] [avae] AVAEInternal.h:70:_AVAE_Check: required condition is false: [AVAEGraphNode.mm:851:CreateRecordingTap: (nullptr == Tap())] 2019-04-09 14:17:55.617660-0700 Runner[33324:2600082] *** Terminating app due to uncaught exception 'com.apple.coreaudio.avfaudio', reason: 'required condition is false: nullptr == Tap()' *** First throw call stack: ( 0 CoreFoundation 0x00000001082166fb __exceptionPreprocess + 331 1 libobjc.A.dylib 0x00000001077baac5 objc_exception_throw + 48 2 CoreFoundation 0x0000000108216482 +[NSException raise:format:arguments:] + 98 3 AVFAudio 0x000000011ec51f3c _Z19AVAE_RaiseExceptionP8NSStringz + 156 4 AVFAudio 0x000000011ecb0937 _Z11_AVAE_CheckPKciS0_S0_b + 295 5 AVFAudio 0x000000011ec6dbe0 _ZN17AUGraphNodeBaseV318CreateRecordingTapEmjP13AVAudioFormatU13block_pointerFvP16AVAudioPCMBufferP11AVAudioTimeE + 116 6 AVFAudio 0x000000011ec4cb5a _ZN18AVAudioEngineGraph16InstallTapOnNodeEP11AVAudioNodemjP13AVAudioFormatU13block_pointerFvP16AVAudioPCMBufferP11AVAudioTimeE + 218 7 AVFAudio 0x000000011ecbbc85 _ZN17AVAudioEngineImpl16InstallTapOnNodeEP11AVAudioNodemjP13AVAudioFormatU13block_pointerFvP16AVAudioPCMBufferP11AVAudioTimeE + 13 8 AVFAudio 0x000000011ecac06c -[AVAudioNode installTapOnBus:bufferSize:format:block:] + 208 9 speech_recognition 0x000000010773f017 $s18speech_recognition28SwiftSpeechRecognitionPluginC5start33_5E733C6DAD67387E5EE9E83523EF0FD9LL4langySS_tKF + 1863 10 speech_recognition 0x000000010773e3f3 $s18speech_recognition28SwiftSpeechRecognitionPluginC05startE033_5E733C6DAD67387E5EE9E83523EF0FD9LL4lang6resultySS_yypSgXEtF + 675 11 speech_recognition 0x000000010773cefa $s18speech_recognition28SwiftSpeechRecognitionPluginC6handle_6resultySo17FlutterMethodCallC_yypSgctF + 1066 12 speech_recognition 0x000000010773d34b $s18speech_recognition28SwiftSpeechRecognitionPluginC6handle_6resultySo17FlutterMethodCallC_yypSgctFTo + 139 13 Flutter 0x00000001039447ba __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 115 14 Flutter 0x00000001039614ac _ZNK5shell21PlatformMessageRouter21HandlePlatformMessageEN3fml6RefPtrIN5blink15PlatformMessageEEE + 166 15 Flutter 0x0000000103964ff0 _ZN5shell15PlatformViewIOS21HandlePlatformMessageEN3fml6RefPtrIN5blink15PlatformMessageEEE + 38 16 Flutter 0x00000001039b7ca7 _ZNSt3__110__function6__funcIZN5shell5Shell29OnEngineHandlePlatformMessageEN3fml6RefPtrIN5blink15PlatformMessageEEEE4$_27NS_9allocatorIS9_EEFvvEEclEv + 57 17 Flutter 0x0000000103970e0e _ZN3fml15MessageLoopImpl15RunExpiredTasksEv + 522 18 Flutter 0x000000010397418c ZN3fml17MessageLoopDarwin11OnTimerFireEP16__CFRunLoopTimerPS0 + 26 19 CoreFoundation 0x000000010817e3e4 CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION + 20 20 CoreFoundation 0x000000010817dff2 __CFRunLoopDoTimer + 1026 21 CoreFoundation 0x000000010817d85a __CFRunLoopDoTimers + 266 22 CoreFoundation 0x0000000108177efc __CFRunLoopRun + 2220 23 CoreFoundation 0x0000000108177302 CFRunLoopRunSpecific + 626 24 GraphicsServices 0x000000010bc6f2fe GSEventRunModal + 65 25 UIKitCore 0x0000000112314ba2 UIApplicationMain + 140 26 Runner 0x000000010092a1c8 main + 72 27 libdyld.dylib 0x00000001092a4541 start + 1 28 ??? 0x0000000000000001 0x0 + 1 ) libc++abi.dylib: terminating with uncaught exception of type NSException

robsonmeemo avatar Apr 09 '19 21:04 robsonmeemo

Can you please accept the PR to fix this crashing bug and release a new version? Thanks!

robsonmeemo avatar May 10 '19 21:05 robsonmeemo

Unfortunately this project seems to be abandoned :( I'll have to fork it and release a new version.

robsonmeemo avatar May 25 '19 04:05 robsonmeemo

ping

robsonmeemo avatar Aug 23 '19 20:08 robsonmeemo

@robsonfingo hi, I am still getting the same issue. Did you try with the latest iOS version on iPhone 11 (simulator)?

*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff23c4f02e __exceptionPreprocess + 350
	1   libobjc.A.dylib                     0x00007fff50b97b20 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff23c4eda8 +[NSException raise:format:arguments:] + 88
	3   AVFAudio                            0x00007fff20a7df67 _Z19AVAE_RaiseExceptionP8NSStringz + 156
	4   AVFAudio                            0x00007fff20a7de80 _Z11_AVAE_CheckPKciS0_S0_b + 326
	5   AVFAudio                            0x00007fff20ac51ce _ZN17AUGraphNodeBaseV318CreateRecordingTapEmjP13AVAudioFormatU13block_pointerFvP16AVAudioPCMBufferP11AVAudioTimeE + 116
	6   AVFAudio                            0x00007fff20ab9ccb _ZN18AVAudioEngineGraph16InstallTapOnNodeEP11AVAudioNodemjP13AVAudioFormatU13block_pointerFvP16AVAudioPCMBufferP11AVAudioTimeE + 389
	7   A<…>

abianche avatar Nov 06 '19 18:11 abianche

I've been using a fork that contains this PR

robsonmeemo avatar Nov 06 '19 18:11 robsonmeemo

@robsonfingo can you share it with me pls? thanks a lot!

abianche avatar Nov 06 '19 18:11 abianche

https://github.com/robsonfingo/speech_recognition/tree/patch-1

robsonmeemo avatar Nov 06 '19 18:11 robsonmeemo