audioplayer icon indicating copy to clipboard operation
audioplayer copied to clipboard

updated deprecated code

Open ThinkDigitalSoftware opened this issue 5 years ago • 8 comments

The program was using an outdated API method and that's been updated. Also, I deleted the widget test code that was throwing an error.

ThinkDigitalSoftware avatar Jul 14 '18 04:07 ThinkDigitalSoftware

I went ahead and forked this project and added this PR (with the fix to pull gradle down) and it is available at https://github.com/emostar/audioplayer and published at https://pub.dartlang.org/packages/audioplayer2

emostar avatar Aug 28 '18 19:08 emostar

Cool, thanks. There are many forks out there, I just need one to follow, lol. I'm having an issue where it's not always notifying the os that the file has played. Still diagnosing it. Also, I think development on this current branch is abandoned.

On Tue, Aug 28, 2018, 12:33 PM Emostar [email protected] wrote:

I went ahead and forked this project and added this PR (with the fix to pull gradle down) and it is available at https://github.com/emostar/audioplayer and published at https://pub.dartlang.org/packages/audioplayer2

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rxlabz/audioplayer/pull/50#issuecomment-416712661, or mute the thread https://github.com/notifications/unsubscribe-auth/AV-HfThGu9Pud2S-zmIt4vU0g5xVFYdgks5uVZsEgaJpZM4VPuiC .

ThinkDigitalSoftware avatar Aug 28 '18 20:08 ThinkDigitalSoftware

Yeah, I'm trying to merge in the PRs to make the new repo be the definitive repository, so there are less forks.

Which event(s) are you not receiving and on which OS?

On Tue, Aug 28, 2018, 10:26 Jonathan White [email protected] wrote:

Cool, thanks. There are many forks out there, I just need one to follow, lol. I'm having an issue where it's not always notifying the os that the file has played. Still diagnosing it. Also, I think development on this current branch is abandoned.

On Tue, Aug 28, 2018, 12:33 PM Emostar [email protected] wrote:

I went ahead and forked this project and added this PR (with the fix to pull gradle down) and it is available at https://github.com/emostar/audioplayer and published at https://pub.dartlang.org/packages/audioplayer2

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rxlabz/audioplayer/pull/50#issuecomment-416712661, or mute the thread < https://github.com/notifications/unsubscribe-auth/AV-HfThGu9Pud2S-zmIt4vU0g5xVFYdgks5uVZsEgaJpZM4VPuiC

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rxlabz/audioplayer/pull/50#issuecomment-416728761, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL2r4CWr8gUgd7hbaI4ng6LA3tyrYm0ks5uVaePgaJpZM4VPuiC .

emostar avatar Aug 28 '18 20:08 emostar

It wasnt changing the state to playing, so. My streambuilder widget wasn't firing until the AudioPlayerState.STOPPED came through the stream, which was the first event. This doesn't happen when running on Android.

On Tue, Aug 28, 2018, 1:52 PM Emostar [email protected] wrote:

Yeah, I'm trying to merge in the PRs to make the new repo be the definitive repository, so there are less forks.

Which event(s) are you not receiving and on which OS?

On Tue, Aug 28, 2018, 10:26 Jonathan White [email protected] wrote:

Cool, thanks. There are many forks out there, I just need one to follow, lol. I'm having an issue where it's not always notifying the os that the file has played. Still diagnosing it. Also, I think development on this current branch is abandoned.

On Tue, Aug 28, 2018, 12:33 PM Emostar [email protected] wrote:

I went ahead and forked this project and added this PR (with the fix to pull gradle down) and it is available at https://github.com/emostar/audioplayer and published at https://pub.dartlang.org/packages/audioplayer2

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/rxlabz/audioplayer/pull/50#issuecomment-416712661 , or mute the thread <

https://github.com/notifications/unsubscribe-auth/AV-HfThGu9Pud2S-zmIt4vU0g5xVFYdgks5uVZsEgaJpZM4VPuiC

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rxlabz/audioplayer/pull/50#issuecomment-416728761, or mute the thread < https://github.com/notifications/unsubscribe-auth/AAL2r4CWr8gUgd7hbaI4ng6LA3tyrYm0ks5uVaePgaJpZM4VPuiC

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rxlabz/audioplayer/pull/50#issuecomment-416736278, or mute the thread https://github.com/notifications/unsubscribe-auth/AV-HfbZ1DOfw2FhrBCT9tMSoyza-S_6Zks5uVa17gaJpZM4VPuiC .

ThinkDigitalSoftware avatar Aug 28 '18 21:08 ThinkDigitalSoftware

Also, can you update the upper SDK constraints to 3.0?

ThinkDigitalSoftware avatar Aug 28 '18 21:08 ThinkDigitalSoftware

Can you file the bug report at https://github.com/emostar/audioplayer/issues, with a sample to reproduce it? I haven't looked into iOS yet with this, as I develop on Android.

emostar avatar Aug 28 '18 23:08 emostar

@emostar, you don't have an issues section on your fork? I need to submit one

ThinkDigitalSoftware avatar Aug 30 '18 21:08 ThinkDigitalSoftware

@ThinkDigitalRepair It's enabled now, not sure why it was off by default.

emostar avatar Aug 30 '18 23:08 emostar