log.c icon indicating copy to clipboard operation
log.c copied to clipboard

Renames log level enum values to not conflict with syslog

Open chiefnoah opened this issue 5 years ago • 5 comments

LOG_DEBUG conflicts with another enum definition in syslog.h, which causes compilation errors when included. This renames the enum values to be prefixed with LOGC instead of LOG to avoid this.

This addresses #3.

chiefnoah avatar Mar 07 '20 21:03 chiefnoah

Ah I was just about to open my own PR for this for the same reason! Has this been forgotten about or does something more need to be done?

detly avatar Aug 30 '20 23:08 detly

I haven't received any feedback, so not sure. I rebased my branch so feel free to use my fork

chiefnoah avatar Aug 31 '20 02:08 chiefnoah

@chiefnoah Thanks for doing this. Did you also have code to log to syslog?

tachang avatar Jan 01 '21 18:01 tachang

@chiefnoah Thanks for doing this. Did you also have code to log to syslog?

It's been awhile, but I believe I was trying to compile something with a library that used syslog, not use it directly myself.

chiefnoah avatar Jan 01 '21 20:01 chiefnoah

Hello, I found your pull-request useful and merged it to my fork ! Feel free to propose changes, thanks for your contribution :smiley: https://github.com/BDeliers/log.c

Balth-D avatar Aug 25 '23 07:08 Balth-D