Rectangle icon indicating copy to clipboard operation
Rectangle copied to clipboard

When setting keyboard shortcuts, existing Rectangle shortcuts continue to have effect

Open finite-state-machine opened this issue 5 years ago • 1 comments
trafficstars

macOS version: 10.14.6 (18G103) Rectangle version: v0.31 (36)

When setting keyboard shortcuts, shortcuts which are already assigned continue to have effect, interfering with the shortcut selection process.

A user new to Rectangle attempts to assign a keyboard shortcut which happens to conflict with one of Rectangle's default shortcuts:

  1. The user opens the Rectangle preferences pane and selects the shortcuts tab.
  2. S/he clicks the shortcut box next to one of Rectangle's actions.
  3. S/he then presses a key combination which happens to already be assigned (by default) to some other action.

Expected behaviour: show a message about a conflicting choice of shortcuts (and perhaps ask the user if they want to override the existing shortcut.)

Actual behaviour: the Rectangle preferences window jumps around in unexpected ways. Rectangle continues to prompt the user to select a shortcut.

On a personal note, thanks for a brilliant piece of software! I hope this bug report will prove useful.

logs (showing that the preferences window was moved, rather than assigning the shortcut as expected): 2020-07-19T10:57:23-04:00: AX sizing proposed: (697.0, 433.0), result: (697.0, 433.0) 2020-07-19T10:57:23-04:00: AX position proposed: (1572.0, 835.0), result: (1572.0, 835.0) 2020-07-19T10:57:23-04:00: AX sizing proposed: (697.0, 433.0), result: (697.0, 433.0) 2020-07-19T10:57:23-04:00: center | display: (0.0, 80.0, 3840.0, 2057.0), calculatedRect: (1572.0, 835.0, 697.0, 433.0), resultRect: (1572.0, 835.0, 697.0, 433.0)

finite-state-machine avatar Jul 19 '20 15:07 finite-state-machine

Any existing keyboard shortcut being pressed should indeed be ignored:

  1. Ignore the window change behaviour (if any, not all always have a visible effect).
  2. Notify the user that the shortcut is already assigned to another action.

Optionally, the user might want to unset the existing binding in the process.

erikhuizinga avatar Aug 01 '20 06:08 erikhuizinga