Insufficient test cases for native code compilation

[JackTemaki]

Removing the -std=... flag as default in #896 caused the breaking of many setups, as the i6 environment is not properly reflected by the automatic test.

Before we continue altering code related to native op compilation, we should think about how we can add specific test cases that will guarantee that the master branch keeps working with our daily work environments.

[JackTemaki]

I think one starting point would be to have certain test cases that are configured with: runs-on: ubuntu-16.04

[albertz]

Can you open a separate issue also about what exactly broke, with some details what broke?

[albertz]

Removing the -std=... flag as default in #896 ...

Also, the flag was not removed?

[albertz]

I think one starting point would be to have certain test cases that are configured with: runs-on: ubuntu-16.04

I think Ubuntu 18.04 is the oldest Ubuntu version which is supported. But also, Ubuntu 18 support might be dropped soon. Ubuntu 22 will be released soon.

[JackTemaki]

Also, the flag was not removed?

It was removed. It now only exists within the OpCodeCompiler but not within the NativeCodeCompileranymore.

I think Ubuntu 18.04 is the oldest Ubuntu version which is supported.

Yes, seems so. But we still need to have a solution for this. Maybe we can add a custom runner, so one machine in our cluster that executes some tests.

[albertz]

Also, the flag was not removed?

It was removed. It now only exists within the OpCodeCompiler but not within the NativeCodeCompileranymore.

Why is that relevant? You always use OpCodeCompiler.

I think Ubuntu 18.04 is the oldest Ubuntu version which is supported.

Yes, seems so. But we still need to have a solution for this. Maybe we can add a custom runner, so one machine in our cluster that executes some tests.

Can you make an issue with some details about the exact problem you got? Maybe this is not really related to Ubuntu 16 and so we don't need such a complex solution? And also, it's anyway not possible to test everything. I don't think we really need a solution for this. This is really such a rare thing, which will soon be completely obsolete.

[JackTemaki]

Why is that relevant? You always use OpCodeCompiler.

That is what I thought as well, but it seems not.

Can you open a separate issue also about what exactly broke, with some details what broke?

#902

This is really such a rare thing, which will soon be completely obsolete.

I do not think this is a rare thing. And this will also not be obsolete. I am not sure how quick the clusters will be updated, and even if we update it, then we might run into the same issues again in 3-4 years when github removes Ubuntu 20 from its list.