rwrx
rwrx
Ok, I can create a new test file, but could I ask you for explanation of the rules for creating names for test files? As of now, I don't know...
@nvkelso Done. But tests are failing, I suspect that this is what you explained in previous comment: "There are unrelated OSM data changes causing some other existing tests to fail....
@nvkelso is there something I can fix here in order for this PR to be merged?
@nvkelso thank you a lot. I have updated this branch. Also I have questions about these PRs: https://github.com/tilezen/vector-datasource/pull/1927 https://github.com/tilezen/vector-datasource/pull/1928 https://github.com/tilezen/vector-datasource/pull/1929 https://github.com/tilezen/vector-datasource/pull/1930 https://github.com/tilezen/vector-datasource/pull/1931 https://github.com/tilezen/vector-datasource/pull/1932 Thank you.
@nvkelso thank you. Should I close this PR in favor of #2025 when you will include changes from this PR into it?
I have updated this PR. I hope that now it is ok.
I am not sure which number for `fell` should I set. I have looked at `bare_rock`, `desert`, `grassland`, `heath`, `sand`, `shingle` and they does not have set `sort_rank`. I haven't...
I have updated sort and collision ranks, but now Circle is complaining that there is no 265 sort rank, because I have incremented it to 266: dam,LineString;MultiLineString,266 I am not...
I have added test, but I am not sure into which file I should have put it in and I am not sure whether it is correctly written.
It is this lastest commit to master branch: https://github.com/mapzen/android/commit/ad7898be5ab5815900cf7572639e00cff1a3aa9d . Hope this helps :).