Raoul Wols comments

Results 283 comments of


                                            Raoul Wols

Avoid killing server before it had chance to shut down gracefully

When the server is closed gracefully, we should be waiting at least 1 second after notifying with “exit”. Does this not happen?

Avoid killing server before it had chance to shut down gracefully

See https://github.com/sublimelsp/LSP/blob/82120a8b67124c22ea01d2723c6a63a3150f5936/plugin/core/transports.py#L119

Avoid killing server before it had chance to shut down gracefully

In the case of ST app shutdown, we are given a blocking exit handler, so we must kill all subprocesses immediately, unfortunately (although I have a few ideas around this)....

Avoid killing server before it had chance to shut down gracefully

I downloaded the latest terraform-ls binary and am using this config ```js "terraform": { "command": [ "$home/Downloads/terraform-ls", "serve" ], "selector": "source.terraform", "enabled": true }, ``` and used this hello world...

Avoid killing server before it had chance to shut down gracefully

Also, according to the spec: > Clients must not send any notifications other than exit or requests to a server to which they have sent a shutdown request. If a...

Applying large text edits results in the viewport shifting to the right

We could try adding caret stability functionality but something general for all language servers is going to be complex. The first thing that comes to mind is to check whether...

Applying large text edits results in the viewport shifting to the right

There's also https://docs.python.org/3/library/difflib.html#sequencematcher-objects

Applying large text edits results in the viewport shifting to the right

It should also be a server setting because for example clangd already has minimal text changes. It would be a waste of CPU cycles to do it again ourselves.

Applying large text edits results in the viewport shifting to the right

See: https://github.com/sublimehq/sublime_text/issues/4144

Cancel inflight view requests when the view closes or when the view state changes

We should cancel textDocument/documentHighlight when the selection changes.