Multiplayer
Multiplayer copied to clipboard
Multiplayer Patches Not Guarded Against Singleplayer Use
Label: 1.6, 1.5, enhancement, low prio
Issue:
Missing Multiplayer.Client == null Guard in MultifactionPatches.cs
While working on the Camp Abandon fix #603 , I discovered that one of our multifaction patches does not include a guard for Multiplayer.Client == null. This caused our mod to introduce a bug into singleplayer as well.
There is atleast on other patch in MultifactionPatches.cs that also lacks the Multiplayer.Client == null check.
TODO:
It would be good to review ALL patches where this guard might be necessary. However, I don't know if this can be done without much consideration, because some patches might not need this guard.