Multiplayer icon indicating copy to clipboard operation
Multiplayer copied to clipboard

Fix errors caused by pocket maps with Multifaction/spectator faction

Open SokyranTheDragon opened this issue 1 year ago • 4 comments

FactionRepeater ends up repeating Storyteller.StorytellerTick for all factions (including spectator, even with Multifaction off). This causes issue due to StorytellerUtility.DefaultThreatPointsNow using Find.AnyPlayerHomeMap if the target is a pocket map, which for factions without a home map will return null and cause NullReferenceException.

SokyranTheDragon avatar Jun 18 '24 19:06 SokyranTheDragon

Looking a bit deeper, it seems there may be some bigger issue at play here. I've seen a couple of more errors that happened due to spectator faction (multifaction off). Would need more investigation.

SokyranTheDragon avatar Jun 22 '24 15:06 SokyranTheDragon

Is my log the same as this bug? This issue has occurred 100+ times. Desync-118.zip

coldliang avatar Jun 23 '24 18:06 coldliang

Is my log the same as this bug? This issue has occurred 100+ times. Desync-118.zip

Unrelated.

SokyranTheDragon avatar Jun 23 '24 21:06 SokyranTheDragon

Could this be what is causing the double quests to spawn? If the storyteller is ticking for both the player and the spectator at the same time, and then try to generate a quest for both, would it be possible that it just spawns 2 quests for the player faction?

SokyranTheDragon avatar Jun 27 '24 21:06 SokyranTheDragon