Multiplayer icon indicating copy to clipboard operation
Multiplayer copied to clipboard

Fix FloatMenuMakerMap.AddHumanlikeOrders sync delegates

Open SokyranTheDragon opened this issue 10 months ago • 1 comments

Comparing the comment of what the delegate was supposed to do with the actual code:

  • The arrest delegate was pointing at ingest
  • The rescue delegate was pointing at capture prisoner
  • The capture slave delegate was pointing at rescue
  • The capture prisoner delegate was pointing at carry to cryptosleep casket
  • The carry to cryptosleep casket delegate was pointing at (bool) check if the thing is a shuttle and allows for the target to be hauled to it
  • The carry to shuttle delegate was pointing at create confirmation for hacking enemy terminal (the option didn't even work due to the 'carry to cryptosleep casket' delegate breaking it, preventing it from appearing)
  • The other FloatMenuMakerMap delegates were correct

I realized something is wrong while investigating this list by @notfood: https://github.com/rwmt/Multiplayer/pull/428#issuecomment-2001661491

SokyranTheDragon avatar Apr 01 '24 16:04 SokyranTheDragon

I've switched the branch from master to rw-1.4. I'll try to go through 1.5 sync methods and delegates later today and clean them up.

SokyranTheDragon avatar Apr 06 '24 16:04 SokyranTheDragon

I''ll close it, we don't support 1.4 anymore

Zetrith avatar May 24 '24 21:05 Zetrith