Ryan Williams

Results 20 comments of Ryan Williams

> @rwilliams3088 Could you please fix the tests so that your fix becomes ready to merge? It would be super useful. Thank you for your work. If you pull it...

> Will this merged soon? I just submitted some revisions based upon the feedback above; waiting for the updates to be reviewed.

@NicoAdrian I only created the PR; it's up to whoever is maintaining this project to review and merge it. I have no clue what's going on behind the scenes. I'd...

I ran into this same issue today - and since it was causing React rendering errors in the console, I decided to go ahead and put together a fix: https://github.com/remix-run/react-router/pull/10740

Seeing this same behavior...

@hahmed Actually, after a bunch of debugging, I found an error on my end where an exception handler was causing the session to get reset (doh!). So it's working OK...

+1. If I tell it the placement then it should be respected.

+1. Critical error for a test framework.

> any downside to doing this instead? I prefer it because it doesn't rely on a ref to pass the previous state to the setter function You can download the...