Ralf W. Grosse-Kunstleve
Ralf W. Grosse-Kunstleve
Logging my thoughts after looking for a bit. That's a lot of code (cost). What's the benefit? It makes sense to distinguish between ints of different sizes etc. for large...
> As long as this goes in the separate numpy.h header, I think better numpy scalar support is reasonable to add. Thanks for pointing out @ax3l, I hadn't given that...
> tried to call pure virtual function > The smart holder branch seems intended to solve this very issue. Only if there is actually a lifetime issue (with pybind11 master),...
> Seeing that it works without deriving from `py::trampoline_self_life_support`, I'm curious as to what the purpose of inheriting from this class is? Did you see this already? https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst#trampolines-and-stdunique_ptr Takeaway: *...
> > Or do you think we need to PYBIND11_EXPORT ‘trampoline_self_life_support’? (I hope not, but it totally depends, I guess.) > > I'm curious, why would we not export this...
Unrelated to this issue, I recently got to understand more about `-fvisibility=hidden` and `namespace pybind11 __attribute__((visibility("hidden")))` (pybind11/detail/common.h). My thinking now: * Exporting `py::trampoline_self_life_support` is definitely not the right approach, because...
Did you already run the full reproducer with sanitizers (valgrind, asan, msan)? It's not certain that the problem here is related to work I did, although it could be. Reading...
> I think I've got a pretty decent handle on the root cause so I can try to make a minimal reproducer. Sounds promising, I'll wait for that. (I cannot...
> To fix the ODR, I added a lint rule to our project to force all includes of pybind.h to go through a helper header, which ensures that all the...
If you're affected by this issue, please check out the smart_holder branch, it is solved there: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst