Ralf W. Grosse-Kunstleve
Ralf W. Grosse-Kunstleve
> @rwgk i added a test too, which I am building locally now - will push once i have it Sounds good, definitely add tests first. After the new tests...
> Changing the name defies the purpose of this, because `operator()` is something Eigen already has (and most multi-dim containers do too for indexing) so that is why i was...
> so you are suggesting doing this? Yes.
I think I misunderstood the existing code (silly in hindsight). This is just checking the number of dimensions: * https://github.com/pybind/pybind11/blob/2fb3d7cbde264a0b3f921e802f287195387e8263/include/pybind11/numpy.h#L1096-L1098 But that's not what I would think of as a...
I could only glance through quickly right now. What I saw looks great. I'll look carefully in the morning.
> One important note is that we technically already had this feature, but it was a poorly (IMHO) designed thing involving proxies. Oh ... I wasn't aware of that TBH....
To explain where my thinking is coming from: * I find that my life is consumed by mopping up little messes created by **divergence** of some sort of another. This...
Re https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2128r6.pdf Thanks for pointing out, I wasn't aware of this before. I want to share a long-term experience, FWIW. A very long time ago I implemented an "array family"...
I'm a believer in numbers and reason. Personal preferences are are a rare luxury for greenfield situations. > (see my example at top) Sorry I'm failing to make the connection,...
Hi again @eacousineau, this is a one-line change that LGTM, but I don't know much about cmake. Could you please help? Or anyone else familiar with cmake seeing this: could...