Richard West

I still think we should check for which reaction rates this is true and just remove them from our libraries, or stop using those libraries, or fix them. Rather than...


If it runs, as you say, then I think you have solved the how to run it question? What remains is why something crashes after many iterations. And for that...

@ntietje1 rebased this for us (thanks!). I just force pushed. let's see if it works.

Didn't mean to close. Just force pushed an update, which then had no commits, and github closed the PR. Have now incorporated #2444 which switches us to the conda-forge version...

On my Mac, just creating an empty conda environment and requesting only pyrms ``` conda create --name rmgtest1 rmg::pyrms Channels: - defaults - conda-forge - rmg Platform: osx-64 pyrms rmg/osx-64::pyrms-0.1.2-no_rmg_dep...

In commit 19124e79f6c501f69eadd9a2ed5c58723e9ecb1b on May 4 the CI installed ``` pyjulia 0.6.1 rmg_1 rmg pyrms 0.1.2 no_rmg_dep rmg ``` Same in f4d7e9c13ee4c47aa4592908ae461595fe7e77e9 on May 8 Same in 8cfbf5cdb26d238c30a898fafa5b8ec2d2c35249 on May...

I've just rebased this onto the official main. I'm not sure why we'd ever have a negative `E0`, based on Blowers and Masel's plots? Doesn't seem to make sense. But...

Is it these ones, Matt? https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2277

I think this may address https://github.com/ReactionMechanismGenerator/RMG-Py/issues/1748 but this PR may be superseded by #2277 (and is likely incompatible with it).