Richard West
Richard West
Hi @mjohnson541 how do we deal with this PR with 110 commits and 557 files? There are a lot of conflicts. Do we just pick out what *needs* to change...
Is this issue fully addressed by #478 and #473 and other thermo group improvements? can it be closed?
> we missed one of the groups (line 54 of the non-ring data file). Good job catching that! It's too easy when reviewing to forget about what isn't shown in...
Based on the discussion above I approve. But I like the idea of better unit tests. Separate issue or add here?
There are many linked and related PRs here, that we should either merge or close, before we *completely* forget what's going on and all the work is wasted. My impression...
I just discovered this project dashboard https://github.com/orgs/ReactionMechanismGenerator/projects/4 which looks promising but somehow was last updated in February 2022, some 16 months ago. Can it be resurrected? Is anyone still around...
Please could you comment on this bit: > (This increasing the E with O coverage may also reduce the need for your ad hoc adjustment of +47.4 kJ/mol to the...
Sounds like a reasonable idea. Would leave H migration unperturbed; speed up generation of models with no halogens; and avoid the very different rates from influencing each other.
I have only just spotted this Issue - just as I was preparing to post about https://fuelmech.org/press/c3-releases-first-of-its-kind-detailed-chemical-kinetic-mechanism-for-surrogate-fuels in the RMG slack channel I thought I'd search the issue board. (If...
## Short term _as discussed 2021-04-12 on Northeastern/Brown call_ * In all surface families treat all O2(g) as being the triplet `[O][O]`. * Ensure the triplet can react. So that...