jquery-datatables-rails icon indicating copy to clipboard operation
jquery-datatables-rails copied to clipboard

Ruby Sass End of Life

Open dillonwelch opened this issue 6 years ago • 6 comments

https://github.com/rails/rails/issues/32896

https://github.com/rails/sass-rails/issues/420

Looks like sass-rails is being end of life'd on 26 March 2019.

dillonwelch avatar Sep 24 '18 17:09 dillonwelch

This gem has dependency sass_rails which use sass too. Ruby Sass is deprecated and will be unmaintained as of 26 March 2019. Will you update dependency to use sassc_rails? Thank you.

http://sass.logdown.com/posts/7081811

xinlangzi avatar Dec 19 '18 03:12 xinlangzi

I have forked this repo with a version that replaces the sass-rails dependency with sassc-rails. People are welcome to use it.

https://github.com/marlinpierce/jquery-datatables-rails

marlinpierce avatar Jan 14 '19 16:01 marlinpierce

@marlinpierce do you want to create a PR? perhaps it would be considered then.

jakeonfire avatar Jan 26 '19 06:01 jakeonfire

@jakeonfire I already created a PR, 12 days before you posted.

marlinpierce avatar Jan 30 '19 13:01 marlinpierce

Here's an approach which we might be doing at our company.

The only things that the jquery-datatables-rails gem does is:

  1. Package the datatables javascript plugin.
  2. Include dependencies to set up the backend for rails development using datatables.
  3. Provide some generators.

The first can be accomplished by replacing jquery-datatables-rails with jquery-datatables. This will update the datatables javascript from 1.10.10 from year 2015 to 1.10.19 from 2018. The paths are different, so you will have to change your asset pipeline manifests.

For the second, just add the gems in the dependency. So replace

gem 'jquery-datatables-rails', '~> 3.4.0'

with

gem "jquery-rails", '~> 4.3'
gem "sassc-rails", '~> 2.0'
gem 'jquery-datatables', '~> 1.10.19'

marlinpierce avatar Feb 05 '19 19:02 marlinpierce

This may eventually become a non-issue. The rails-sass gem is being updated with 6.0.0 to just be a wrapper for rails-sassc.

marlinpierce avatar May 03 '19 14:05 marlinpierce