Richard Berendsen

`SecretManager.global_redact` is also called to redact SQL queries. So reducing its functionality to just redacting a dictionary may not suffice, at least not without enabling the same redacting use cases...

The reason is that YAML dump inserts leading spaces after newllines. But the deserialised version does not have leading spaces.

A possible fix that would leave the SecretManager class unaltered would be to use the global_redact function differently when printing the variables to stdout. Rather than dumping `config['vars']` as a...

Another option would be to construct the replacement string in such way that newlines are preserved. This would make redacted output prettier, ar the expense of revealing the location of...

Guess my proposal would be to also match indented multiline secrets; and to preserve newlines in masked output

It seems in this line the assumption is that all secrets are of data type str: https://github.com/Snowflake-Labs/schemachange/blob/de2bca1d10e960bf6d9d6580b8ade664fda581aa/schemachange/cli.py#L792 Would it be an idea to log a warning if a value is...

Actually, schemachange crashes if you put, say, an int, as the value for the secret in the schema-config.yml. So, refraining from adding non-str values to the `extracted_secrets` set should not...

Have created a pull request from my fork for this issue, please review if you feel this issue should be tackled: https://github.com/Snowflake-Labs/schemachange/pull/238/files