Ryan Waskiewicz

Results 330 comments of Ryan Waskiewicz

Hey @mikaelkaron 👋 We're working through our dependency updates for Stencil as a whole. There are four rollup packages I believe need to be updated, `@rollup/plugin-node-resolve` among them. I don't...

Thanks for this PR! I see the accompanying issue and have labeled this PR for the team to take a look at both a little more closely.

@awk I think the next steps for this PR is for the team to sit down and review the PR. Specifically, we'll be looking at the changes and convincing ourselves...

In the mean time, I've enabled the rest of CI to run for this PR to make sure the rest of our checks pass

Thanks @kraftwer1! I see what you mean - I'm going to label this for the team to take a closer look

Doing a final review/test now. @tanner-reits can you get started on the docs for this?

@tanner-reits do you have a project template you were using to test this out that @alicewriteswrongs & I could leverage?

@tanner-reits can you provide a step-by-step here? Ideally, we should be able to reproduce your testing steps from the "Testing" section of the PR summary. Right now it's not clear...

@tanner-reits I gave this a run through with the steps provided, and couldn't get this to work quite right. I'm sure it's probably I'm doing on my end - to...

Ah I knew it was something silly 🤦 Thanks!