Rick Waldron

Results 213 comments of Rick Waldron

Is there a test plan for making sure nothing that relies on these implementations is broken?

> The I2C address of my generic BME280 board is not the default. I think the default address is set for Adafruit boards. From the datasheet: > Connecting SDO to...

Thanks for the update!

IIUC, the breakage is trivial to fix: just add HardwareSerial.h?

> I have a hard time making the call to make potentially breaking changes. I'm no stranger. I'm going to leave an inline comment for you momentarily.

Actually, let's get @resseguie @julian_duque @lyzadanger to weigh in on that, since they've done the most work with Piezo

I've read the PR and there are a few places you could be more specific, but I also noted that those places were marked with "TODO", so I will let...