Roman Volosatovs

Results 79 comments of Roman Volosatovs

Indeed, didn't see this in the spec before. We'll have to do some refactoring to allow for this. Also, how would this work for ABP? I suppose we will still...

Well, the most important point here is that, apparently, compiling our current protocol buffers is not a straight-forward process for users. It is not realistic to attempt to provide compiled...

a.) In v4 we could try b.) This is also why I suggest to have a tool, which would let us selectively choose entities to "export", we could also just...

What input is required from us (@rvolosatovs @johanstokking @htdvisser)? Is this issue missing a `discussion` label? FTR, I think it depends on what fields we're talking about, but for LoRaWAN-specific...

Validation plugin we're using dropped support for GoGo https://github.com/envoyproxy/protoc-gen-validate/pull/340

I think the best way forward would be to first try out https://github.com/alta/protopatch. Depending on the result: - If all our needs are covered -> migrate and forget about this(should...

The huge migration burden and loads of boilerplate if we end up just using vanilla protos directly. I don't really object to that though, I just think we should try...

I really wish I could write down a step-by-step "how to do this right", but I honestly have no idea. Consider consulting @htdvisser regarding this. What I would try to...

I added GoGo support to `protoc-gen-star` directly: https://github.com/lyft/protoc-gen-star/pull/51 Using that functionality I added full support for customname/customtype/casttype/embeded: https://github.com/TheThingsIndustries/protoc-gen-validate/commit/0065acaf05f10558b4d4173f1a109485b2106316 And validation of non-nullable messages: https://github.com/TheThingsIndustries/protoc-gen-validate/commit/228ba7a816cd0d31ce9642ef0e6d6e78788c2d0b If approach in https://github.com/lyft/protoc-gen-star/pull/51 seems viable...

> care about this too. Given that the project is unmaintained for a while https://github.com/gogo/protobuf/issues/691 I would not expect this to happen