rvm1-ansible icon indicating copy to clipboard operation
rvm1-ansible copied to clipboard

Improve Bundler setup to support RVM aliases

Open gildegoma opened this issue 9 years ago • 9 comments

Without this change, the Bundler setup fails when the rvm_rubies list contains valid RVM aliases, like following examples:

  • ruby-1.9.3
  • ruby-2.0
  • 2.1
  • ruby
  • jruby

These aliases are quite useful to refer to the latest release of a specific Ruby branch.

gildegoma avatar Jun 30 '15 07:06 gildegoma

Just noticed that this PR will conflict with #48. No problem for me to integrate this change as well, or rebase if necessary.

gildegoma avatar Jun 30 '15 07:06 gildegoma

@gildegoma Sorry for the late reply but are you thinking to rebase this PR

lpaulmp avatar Nov 30 '16 22:11 lpaulmp

@gildegoma would you mind rebasing this PR?

pkuczynski avatar Jul 21 '20 10:07 pkuczynski

@pkuczynski Sure, I'll do. (Sorry to have missed the previous call, but I wasn't using this role for quite a while...).

gildegoma avatar Jul 22 '20 12:07 gildegoma

No worries. Thanks for looking into it now :) Let me know when it's ready for the review...

pkuczynski avatar Jul 22 '20 12:07 pkuczynski

FYI: @pkuczynski I am waiting for #215 (which fixes the Travis CI setup, and extend the tests so it will be convenient to cover the change proposed here).

gildegoma avatar Jul 23 '20 18:07 gildegoma

@gildegoma seems that this has conflicts. Can you solve them?

pkuczynski avatar Mar 25 '22 21:03 pkuczynski

@pkuczynski this seems to conflict with #235, maybe we should prioritise review/merge of #235 so that the rest can be adapted?

thbar avatar Mar 26 '22 10:03 thbar

#235 is merged... @gildegoma can you rebase?

pkuczynski avatar May 09 '22 21:05 pkuczynski