rvm1-ansible icon indicating copy to clipboard operation
rvm1-ansible copied to clipboard

Published 20 hours ago • verified publisher icon rvm

Travis CI: Verify that "Ansible --check mode" passes

Open gildegoma opened this issue 3 years ago • 10 comments

Initially motivated by #218.

In order to get a build success, this PR (temporarily) includes the changes proposed in #219.

gildegoma avatar Aug 01 '20 15:08 gildegoma

Does not seem to help. The build is still failing :(

pkuczynski avatar Aug 01 '20 16:08 pkuczynski

The CI job detected a new problem, occurring only with the root.yml playbook.

See https://travis-ci.org/github/rvm/rvm1-ansible/jobs/714023964#L296 for instance.

gildegoma avatar Aug 01 '20 16:08 gildegoma

We have updated & tested #219. I believe it will be good to first merge #219, then update #220!

thbar avatar Aug 18 '20 09:08 thbar

Rebased and now ready for review.

gildegoma avatar Aug 19 '20 04:08 gildegoma

Would you mind adding a comment in the code here too to explain running check mode twice? I think that would be helpful for someone looking at the code for the first time without reading our PR comments.

@danochoa thank you for all the feebacks 😃. Yes, if we stick the goal to support "check mode" in any situation, I'll add a comment to try to make things crystal clear.

gildegoma avatar Aug 19 '20 16:08 gildegoma

As we are moving away from Travis to GHA, is this still valid @danochoa ?

pkuczynski avatar Mar 25 '22 20:03 pkuczynski

See #235, which maybe will have to be merged first, to see if current PR is worth adapting to GH actions.

thbar avatar Mar 26 '22 10:03 thbar

@gildegoma as we migrated to Github Actions in #235, is this still somehow valid, and would you like to migrate this to the new CI?

pkuczynski avatar Mar 26 '22 21:03 pkuczynski

Related: https://github.com/rvm/rvm1-ansible/issues/226

thbar avatar Mar 30 '22 12:03 thbar

Ping @gildegoma...

pkuczynski avatar May 09 '22 21:05 pkuczynski