rvm-binary icon indicating copy to clipboard operation
rvm-binary copied to clipboard

Rename binary releases to ruby-bin-...

Open havenwood opened this issue 11 years ago • 8 comments

Adding bin to Ruby binary releases avoids confusion between binary and source releases. So ruby-2.1.0.tar.bz2 binary would become ruby-bin-2.1.0.tar.bz2.

havenwood avatar Jan 08 '14 23:01 havenwood

good point, we had to rename the binaries to bin-* when downloading into rvm/archives to avoid the same problem, would it be an issue if I would name then bin-ruby-* instead of ruby-bin-*?

mpapis avatar Jan 09 '14 14:01 mpapis

It does avoids binary/source confusion either way. I do think ruby-bin-* would be a bit better than bin-ruby-* though. Having source and binary Rubies always start with ruby-* seems like a good thing. Also JRuby is currently doing jruby-bin-* and adopting that convention might be a nice thing for the community going forward.

Not quite as easy as prepending bin- to the name but I think ruby-bin-* may be worth doing? Perhaps something like RUBY_BIN_ARCHIVE="${RUBY_ARCHIVE%%-*}-bin-${RUBY_ARCHIVE##*-}" for a bash substitution solution. Or is bin-ruby-* a preferred naming convention to adopt for other reasons?

havenwood avatar Jan 09 '14 16:01 havenwood

bin-* mostly to limit scope of the changes and to keep compatibility with existing code as rvm 1.x is feature frozen, I'm not sold on the jruby conversion as it requires injecting the -bin- into the name compared to the simple prefixing the name - less code = less errors ...

mpapis avatar Jan 09 '14 16:01 mpapis

the filename bin-ruby looks unusual and strange to me. i would prefer ruby-bin, but then again I'm not writing any code to download these tarballs.

ghost avatar Jan 09 '14 18:01 ghost

@robgleeson I concur. I've only seen project-foo-1.2.3 or project-1.2.3-foo. ruby-2.0.0-bin looks OK.

postmodern avatar Jan 09 '14 18:01 postmodern

+1 for ${ruby_version}-bin

richo avatar Jan 09 '14 19:01 richo

JRuby has used jruby-bin-version and jruby-src-version for many years, so that's my vote.

headius avatar Jan 09 '14 20:01 headius

ruby-bin-version seems most logical

grk avatar Jan 10 '14 12:01 grk