trunk8
trunk8 copied to clipboard
Truncating text with New Line Characters
Thanks for the work on this library. However, recently I noticed an issue where the truncation was failing and causing strange results. After some investigation, it was happening when the text contained a new line character - \n
- and stripHTML: true
, also lines: 2
.
Example input:
This is a long line, it will cause things to start to wrap at some point, what is really happening though
This is a short line.
Output
p This is a long line, it will cause things to start to wrap at wra
I tried to trace the issue a bit and it seems like it's related to https://github.com/rviscomi/trunk8/blob/master/trunk8.js#L54 or https://github.com/rviscomi/trunk8/pull/29. The new line character causes the HTML tags to not be properly open and closed. As a result, the stripped tag gets inserted into the truncated result.
My workaround fix was to strip any \n
characters before passing the input to trunk8.
Thanks!
@ssteeg check this out https://github.com/rviscomi/trunk8/pull/77 , I think it's better than stripping \n
... let me know if this fixes your issue
Thanks @dorilla. I no longer have access to the code where this issue was occurring, so I can't verify. However, it seems like a good step in the right direction 👍