erlog icon indicating copy to clipboard operation
erlog copied to clipboard

Rebarified

Open nisbus opened this issue 12 years ago • 4 comments

Hi,

This is a minor change, basically just rebarifying erlog so it can be used as a rebar dependency.

Added rebar.config, rebar and erlog.app.src for enabling others to use erlog as a rebar dependency. Changed the Makefile to use rebar.

nisbus avatar Feb 17 '13 10:02 nisbus

I will pull this later. It is good you attacked Makefile, the old one was pretty bad. I would like to make it so it uses rebar if it can find rebar, else uses erlc. The lfe Makefile does this but there is probably a better way to do it.

rvirding avatar Feb 17 '13 16:02 rvirding

I think the convention is to include rebar with the repo (I'm not so sure I like that myself) so it is a part of the branch there so it will always find it.

On Sun, Feb 17, 2013 at 4:07 PM, Robert Virding [email protected]:

I will pull this later. It is good you attacked Makefile, the old one was pretty bad. I would like to make it so it uses rebar if it can find rebar, else uses erlc. The lfe Makefile does this but there is probably a better way to do it.

— Reply to this email directly or view it on GitHubhttps://github.com/rvirding/erlog/pull/2#issuecomment-13688104.

nisbus avatar Feb 17 '13 16:02 nisbus

Looking back over old stuff and saw this. The reason why I never pulled it was because it didn't have the option of using either rebar or normal make if there was no rebar. I don't see rebar as the answer. :-)

rvirding avatar Apr 24 '14 21:04 rvirding

My branch has a makefile that handles both cases, so maybe we should just close this PR?

zkessin avatar May 29 '14 03:05 zkessin