CushyStudio icon indicating copy to clipboard operation
CushyStudio copied to clipboard

Write an automated test which pulls a random set of workflows from comfyworkflows.com to test for stability

Open oxysoft opened this issue 2 years ago • 8 comments

Every single workflow I try to import fails. This is a recurrent problem in CushyStudio. So far I have never been able to import my own workflows into CushyStudio in the two months that I have toyed with it on and off. This makes CushyStudio mostly useless so it's very important that we get this essential functionality perfect.

https://comfyworkflows.com/

oxysoft avatar Nov 10 '23 19:11 oxysoft

image

adding that now

rvion avatar Nov 10 '23 21:11 rvion

image

first step: display those in the action picker with their illustration

rvion avatar Nov 10 '23 21:11 rvion

image

all those random workflows picked on https://comfyworkflows.com/ now both show in the library + load when you click on them; (except for the bottom-left one that uses Reroute (rgthree))

rvion avatar Nov 10 '23 22:11 rvion

image

honestly, I won't debug those kind of things 😄 they just don't make any sense in Cushy. I've already added some stuff to support some frontend-only nodes that only exist in the litegraph UI, but that's just the wrong approach; what I want is to be able to load any workflow in the ComfyUi panel (100% of existing workflows are supported there) then allow you to select any subset of nodes => right click => make into prefab => it creates a file ready to be used/and reused across your actions

rvion avatar Nov 10 '23 23:11 rvion

image

I've made the auto-generated form way better; not finished yet, but quite promising

rvion avatar Nov 10 '23 23:11 rvion

image

honestly, I won't debug those kind of things ?? they just don't make any sense in Cushy. I've already added some stuff to support some frontend-only nodes that only exist in the litegraph UI, but that's just the wrong approach; what I want is to be able to load any workflow in the ComfyUi panel (100% of existing workflows are supported there) then allow you to select any subset of nodes => right click => make into prefab => it creates a file ready to be used/and reused across your actions

Lmao I will admit I didn't know the extent to which people pushed this. I still think Cushy should be able to display it at all cost, even if it's just collecting every node into a list for editing and running.

image

I've made the auto-generated form way better; not finished yet, but quite promising

Now that looks more like what I expected going into Cushy Studio. I think you should add a subtle separator between each node in the list, or even better make the background color alternating subtly on a node-by-node basis!

oxysoft avatar Nov 11 '23 01:11 oxysoft

image

some field are now mapped to their better widget alternative

rvion avatar Nov 11 '23 09:11 rvion

respect min, max, step

image

rvion avatar Nov 11 '23 09:11 rvion