SettingsBundle icon indicating copy to clipboard operation
SettingsBundle copied to clipboard

Symfony 6 compatibility

Open studio-m2v opened this issue 2 years ago • 17 comments

Some changes to be compatible with Symfony 6 and PHP 8.x

studio-m2v avatar Apr 09 '22 17:04 studio-m2v

@dmishh can we have this?

brzuchal avatar Jan 03 '23 15:01 brzuchal

What I am curious about is why tests do not get executed. Can you rebase on master?

rvanlaak avatar Jan 03 '23 17:01 rvanlaak

@brzuchal hey, I no longer maintain this repo. Richard is the one :) btw, @rvanlaak do you want to take over this repo? I'd like to transfer it to your account since you're maintaining it like you're the owner. Maybe some listings on the packagist will need to be updated, etc

dmishh avatar Jan 11 '23 14:01 dmishh

@dmishh yes please do!

But, maybe @FriendsOfSymfony or another group is even a better and more sustainable place?

rvanlaak avatar Jan 12 '23 12:01 rvanlaak

@rvanlaak I'd rather transfer to your account since you were the main contributor all the time after I stopped supporting the project. How about the packagist name or anything else required to make the transfer smooth for the users?

dmishh avatar Jan 17 '23 17:01 dmishh

Yes, please feel free to do so.

rvanlaak avatar Jan 21 '23 21:01 rvanlaak

@rvanlaak how about the packagist settings, etc? Should there be some changes, so it doesn't fall apart?

dmishh avatar Jan 24 '23 10:01 dmishh

Can you add me as maintainer on Packagist first? That way I can make sure to update the reference once the ownership on Github was transferred.

rvanlaak avatar Jan 24 '23 12:01 rvanlaak

@rvanlaak I just added you to the maintainers list - https://packagist.org/packages/dmishh/settings-bundle

dmishh avatar Jan 25 '23 08:01 dmishh

Feel free to transfer the repo @dmishh , thanks for your effort!

rvanlaak avatar Jan 25 '23 11:01 rvanlaak

@rvanlaak you need to delete the repo fork in your account first. The error I'm getting during the transfer attempt: "rvanlaak/SettingsBundle already exists"

Please, do so and let me know. Thanks

dmishh avatar Jan 26 '23 09:01 dmishh

Removed my fork ✅

rvanlaak avatar Jan 27 '23 13:01 rvanlaak

@rvanlaak great! "Repository transfer to rvanlaak requested"

Thanks for supporting the bundle!

dmishh avatar Jan 27 '23 16:01 dmishh

Thanks @rvanlaak for takeing over the repo. Please let us know after the transfer is completed and i hope we get symfony 6 support soon.

Chris53897 avatar Feb 05 '23 13:02 Chris53897

@dmishh in order to not mess up possible packagist installations (as I was OoO for some days), I've not accepted the transfer yet and it now has expired. Can you resend it?

rvanlaak avatar Feb 05 '23 16:02 rvanlaak

@rvanlaak yep, I just initiated the transfer again

dmishh avatar Feb 06 '23 11:02 dmishh

Done! Updated the Packagist settings accordingly and left a note on README for clarity. Thank you @dmishh !

rvanlaak avatar Feb 06 '23 12:02 rvanlaak