Ryan Vandersmith

Results 113 comments of Ryan Vandersmith

> ...the mapping will depend on the compiled code and choice of GC. Right; I see what you're saying about this. The assumption is that the external tooling is targeting...

Thanks for taking a look! Adding a warning if a custom RTS function uses `unsafe` Rust seems like a great idea. I also fully agree with your evaluation that this...

My understanding is that this is related to a convention in the `mo-doc` command for specifying file-level doc comments. You should be able to fix this by moving the doc...

> The only worry I have is that users could easily break the memory safety and that we would then get issue reports of memory corruptions in Motoko (which could...

Try upgrading the base library to 0.11.0; this should fix the issue. Context: [developer forum post](https://forum.dfinity.org/t/upcoming-changes-in-motoko-0-11-0/28218)

Relevant source code locations: * [`declaration_header`](https://github.com/dfinity/motoko/blob/404af519fc028a1c5475df3719b16d7a2409aa16/src/docs/plain.ml#L250) * [`plain_of_doc_typ`](https://github.com/dfinity/motoko/blob/404af519fc028a1c5475df3719b16d7a2409aa16/src/docs/plain.ml#L210-L213) * [`extract_doc`](https://github.com/dfinity/motoko/blob/404af519fc028a1c5475df3719b16d7a2409aa16/src/docs/extract.ml#L155-L160) Fixing this seems nontrivial; I encountered a similar issue when implementing type information tooltips in the VS Code extension. @ggreif...

Which version of Node.js is being used in the CI? (Update: it's Node 18.x)

@krpeacock @ZenVoich @dfx-json, these CI errors are apparently caused by the replica timing out rather than an issue with Mops ([relevant log output](https://github.com/dfinity/sdk/actions/runs/4994726218/jobs/8945938611?pr=3038#step:9:675)). I temporarily switched the default `mops.toml` dependencies...

I've run into similar issues in the past; this is a known issue with Vite / esbuild. Your best chance at fixing this would be to open an issue on...

> What do you think about replicating your project in Next.js? I am not super skilled with Java script frameworks like yourself but I am wondering if the same result...