warpd icon indicating copy to clipboard operation
warpd copied to clipboard

Blinking `cursor_color` in normal mode

Open tkna91 opened this issue 2 years ago • 16 comments

I thought it might be easier to recognize cursor_color as an indicator if it blinks when warpd --normal is enabled.

tkna91 avatar Oct 06 '22 21:10 tkna91

This should now be possible by settingnormal_blink_interval.

rvaiya avatar Nov 19 '22 02:11 rvaiya

Thanks. Somehow I think the flashing is hard to recognize. is it a wayland problem?

$ paru -Q warpd-git
warpd-git r248.6d43797-1
$

https://user-images.githubusercontent.com/102382754/202832712-cdd72d0c-e494-4abf-ad98-f1b530838dde.mp4

tkna91 avatar Nov 19 '22 03:11 tkna91

I believe this should be fixed in the latest commit.

rvaiya avatar Nov 23 '22 09:11 rvaiya

warpd seems to be crashing on the latest and stable version of sway. Should I create a new issue? Sorry if I am doing something wrong. 20221123-224953.log

tkna91 avatar Nov 23 '22 13:11 tkna91

Sorry, the previous commit broke a few things. Can you try the latest one?

On Wed, Nov 23, 2022 at 8:52 AM Takahashi, Naoki @.***> wrote:

warpd seems to be crashing on the latest and stable version of sway. Should I create a new issue? Sorry if I am doing something wrong. 20221123-224953.log https://github.com/rvaiya/warpd/files/10076094/20221123-224953.log

— Reply to this email directly, view it on GitHub https://github.com/rvaiya/warpd/issues/174#issuecomment-1325097432, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOP7GIAYH5B6KEKYTEJ4NLWJYOQXANCNFSM6AAAAAAQ7AXHKQ . You are receiving this because you commented.Message ID: @.***>

rvaiya avatar Nov 24 '22 03:11 rvaiya

Still can't seem to get it to work. (sway-im-git has incorporated this patch, but it probably won't affect it. https://github.com/swaywm/sway/pull/5890 ) 20221124-133043.log

tkna91 avatar Nov 24 '22 04:11 tkna91

It seems my wayland optimizations also introduced a multi screen bug. Can you try one more time?

On Wed, Nov 23, 2022 at 11:45 PM Takahashi, Naoki @.***> wrote:

Still can't seem to get it to work. (sway-im has incorporated this patch, but it probably won't affect it. https://github.com/swaywm/sway/pull/5890 ) 20221124-133043.log https://github.com/rvaiya/warpd/files/10080858/20221124-133043.log

— Reply to this email directly, view it on GitHub https://github.com/rvaiya/warpd/issues/174#issuecomment-1325951796, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOP7GMDNDQZBEX7ZQIEDI3WJ3XIBANCNFSM6AAAAAAQ7AXHKQ . You are receiving this because you commented.Message ID: @.***>

rvaiya avatar Nov 24 '22 08:11 rvaiya

Crashes no longer occur. However, the cursor_color does not seem to flash

$ pacman -Q warpd-git sway-im-git wlroots-git linux
warpd-git r251.2f29c37-1
sway-im-git r6998.76232927-1
wlroots-git 0.17.0.r5923.01103e1d-1
linux 6.0.9.arch1-1
$ warpd --normal
wayland: mouse hiding not implemented
$ 

https://user-images.githubusercontent.com/102382754/203743816-526cca11-e8f0-4c7a-ae5d-ba7a076dee1d.mp4

tkna91 avatar Nov 24 '22 09:11 tkna91

Can you try the latest commit?

rvaiya avatar Nov 25 '22 08:11 rvaiya

Done. Thanks!

https://user-images.githubusercontent.com/102382754/203943966-56ec8314-d431-4b06-b1d3-848f672f58d4.mp4

If it's not too hard, it might be nice if the user could adjust the look by specifying a time duration for the light to turn on and off, as shown below.

normal_blink_interval: 500 200

tkna91 avatar Nov 25 '22 09:11 tkna91

specifying a time duration for the light to turn on and off, as shown below.

Can you elaborate? I'm not sure what this means.

rvaiya avatar Nov 25 '22 10:11 rvaiya

It means that it would be nice to be able to specify the ON and OFF times of the blinking respectively.

tkna91 avatar Nov 25 '22 10:11 tkna91

Ah, I see. This has been added to the latest commit.

rvaiya avatar Nov 25 '22 23:11 rvaiya

Thanks. However, the ON status seems to flicker a bit.

https://user-images.githubusercontent.com/102382754/204067322-c411f163-ee86-42ed-911a-22e73da39b9c.mp4

tkna91 avatar Nov 26 '22 01:11 tkna91

The wayland code isn't well optimized and has some limitations. I've included a temporary fix in the latest commit, but you might notice other performance issues which are non trivial to fix. In general, wayland is not well support (a thing I hope to remedy in the keyd implementation).

On Fri, Nov 25, 2022 at 8:31 PM Takahashi, Naoki @.***> wrote:

Thanks. However, the ON status seems to flicker a bit.

https://user-images.githubusercontent.com/102382754/204067322-c411f163-ee86-42ed-911a-22e73da39b9c.mp4

— Reply to this email directly, view it on GitHub https://github.com/rvaiya/warpd/issues/174#issuecomment-1327953647, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOP7GO7O4KDDLGCVAQWHXTWKFSAVANCNFSM6AAAAAAQ7AXHKQ . You are receiving this because you commented.Message ID: @.***>

rvaiya avatar Nov 26 '22 03:11 rvaiya

I Understood. Thank you.

tkna91 avatar Nov 26 '22 03:11 tkna91