ghauth icon indicating copy to clipboard operation
ghauth copied to clipboard

Support upgrading of old token format.

Open bcomnes opened this issue 3 years ago • 2 comments

OK, so github just made us go through an entire rewrite of device flow auth, and then decided to change their token formats.

Now I get an email whenever someone uses my app with an old token 😭

Would it be alright to support transparent token upgrades when an old token is discovered?

https://docs.github.com/en/rest/reference/apps#reset-a-token

(I could implement maybe).

bcomnes avatar Jul 15 '21 14:07 bcomnes

oh joy

I guess transparent upgrades won't be a terrible thing since we're already taking care of the whole creation process anyway. Maybe just print to the console when it's happening though (stderr probably).

Thanks for staying on top of this @bcomnes

rvagg avatar Jul 16 '21 03:07 rvagg

I might be able to invalidate all app tokens as well at a per app level. A bit ham fisted, but that could work too. Ill look into it.

bcomnes avatar Jul 16 '21 15:07 bcomnes