archived-servertest icon indicating copy to clipboard operation
archived-servertest copied to clipboard

fix: update error message for node@9

Open davidguttman opened this issue 7 years ago • 0 comments

This fixes this failing test in node@9

# attach response to err.response and non-enumerable
(node:28879) TimeoutOverflowWarning: 4294967296000 does not fit into a 32-bit signed integer.
Timer duration was truncated to 2147483647.
ok 73 should be equivalent
not ok 74 should be equal
  ---
    operator: equal
    expected: 'Unexpected token O'
    actual:   'Unexpected token O in JSON at position 0'
    at: onReturn (/private/tmp/servertest/servertest.js:88:5)
  ...
ok 75 OK

davidguttman avatar Nov 02 '17 03:11 davidguttman

This is an interest use case, but there are no plans to add this functionality (as far as I know, this module is done). I'm :+1: to have this in, if you would like to submit a PR.

I think we might look into add a splice() method, just like arrays. What do you think, @rvagg @jcrugzz?

mcollina avatar May 25 '15 07:05 mcollina

yeah, I like this, but it'll have to come from a PR with some solid tests

rvagg avatar May 27 '15 02:05 rvagg

:+1: This sounds cool but tricky to implement efficiently.

jcrugzz avatar May 27 '15 05:05 jcrugzz

Looks like I'll be studying the source code now. :)

If I don't go with another approach to solve the problem, I'll be adding this to bl. :)

greduan avatar May 27 '15 13:05 greduan

FYI, I won't be implementing this myself. For the moment I no longer have a need for BufferLists like this. Feel free to leave this open for other people to know it has been requested and/or implement it.

greduan avatar Jun 13 '15 21:06 greduan